IJHack / QtPass / 27694030650

55%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(#1511): inject Pass*/AppSettings into dialog layer (#1553)

* refactor(#1511): inject Pass*/AppSettings into dialog layer

- ImportKeyDialog: constructor now takes const QString &gpgExe;
  importFromString() uses m_gpgExe instead of QtPassSettings::getGpgExecutable();
  removes qtpasssettings.h dependency. Call site in usersdialog.cpp updated.

- PasswordDisplayPanel: displayFields() and appendField() now take
  const AppSettings &s; addField() receives it transitively. Replaces
  four QtPassSettings:: reads (clipBoardType, useQrencode, useMonospace,
  hidePassword) with struct fields; removes qtpasssettings.h dependency.
  Tests updated with AppSettings{} default.

- PasswordDialog (second constructor): signature changed to
  (Pass*, const AppSettings&, QString, bool, QWidget*). Settings
  injected at construction time; m_pass stored as member so
  on_createPasswordButton_clicked() and on_accepted() also use it.
  First constructor still resolves Pass* via QtPassSettings::getPass()
  for test compatibility.

Part of the #1511 AppSettings injection series (PR C).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(review): single-snapshot passShowHandler; document m_pass lifetime

- passShowHandler: replace 7 separate QtPassSettings singleton reads
  with one AppSettings s = QtPassSettings::load() at the top of the
  handler; guard conditions (s.hideContent, s.displayAsIs) and the
  AppSettings passed to displayFields() now come from the same snapshot,
  eliminating the mixed-read inconsistency flagged in PR review.

- PasswordDialog first constructor: add a comment explaining that
  m_pass is captured once from the singleton and that this constructor
  is test-only; production always uses the injected-Pass* overload.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Coverage Stats

11 of 36 new or added lines in 5 files covered. (30.56%)

20 existing lines in 4 files now uncovered.

3966 of 6929 relevant lines covered (57.24%)

23.31 hits per line