IJHack / QtPass / 27691522006

55%

push

github

refactor(#1511): wire AppSettings into ConfigDialog + SshAuthSock (PR B) (#1552)

* refactor(#1511): wire AppSettings into ConfigDialog + SshAuthSock (PR B)

ConfigDialog constructor:
- Load AppSettings once (const AppSettings s = QtPassSettings::load())
  and reuse it — removes two extra getClipBoardTypeRaw()/isUseSelection()
  calls that duplicated the load() done by applySettings()
- Use static_cast<int>(s.clipBoardType) for the combo box index

ConfigDialog destructor:
- Remove three individual setX() calls (setGitExecutable, setGpgExecutable,
  setPassExecutable) that were redundant with on_accepted() calling
  QtPassSettings::save(readSettings()) and wrong on Cancel (they persisted
  changes even when the user dismissed the dialog)
- Destructor is now trivially default

SshAuthSock::initialise():
- Accept override path as a parameter (const QString &override = {})
  instead of reading QtPassSettings::getSshAuthSockOverride() internally
- Removes the qtpasssettings dependency from sshauthsock.cpp
- Caller (main/main.cpp) passes QtPassSettings::getSshAuthSockOverride()
  explicitly, making the data-flow visible at the call site
- Tests updated to pass override directly instead of setting it via
  QtPassSettings (five tests: HonoursExistingEnv, UsesOverride,
  NoOverrideNoEnvProbes, OverrideSkipsAgentValidation,
  EmptyOverrideFallsThrough)

pass.cpp: update TODO to clarify that the static getGpgIdPath chain
  (getGpgIdPath → getRecipientList → getRecipientString) will be
  addressed in the mainwindow PR, not here.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* docs: update SshAuthSock::initialise() comment to reflect parameter API

The implementation note still said it reads
QtPassSettings::getSshAuthSockOverride() directly; since PR B the value
arrives as the `override` parameter instead.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

5 of 6 new or added lines in 2 files covered. (83.33%)

3985 of 6934 relevant lines covered (57.47%)

23.76 hits per line