IJHack / QtPass / 27688530046

55%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(pass): inject AppSettings into Pass hierarchy (PR A of #1511) (#1551)

* refactor(pass): inject AppSettings into Pass hierarchy (PR A of #1511)

- Pass::init(AppSettings) replaces no-arg init(); backends store
  m_settings and read executables/paths from it instead of calling
  QtPassSettings getters at runtime
- ImitatePass::pgit/pgpg converted from static free functions to const
  member functions; grepMatchFile (static) inlines the wslpath check
  using its gpgExe parameter
- PassBackendFactory::getPass() loads AppSettings via QtPassSettings::load()
  and normalises passStore via QtPassSettings::getPassStore(), then passes
  the snapshot to pass->init(s)
- realpass.cpp and imitatepass.cpp no longer include qtpasssettings.h
- Integration test and tst_util updated: call pass.init(s) after
  configuring QtPassSettings so m_settings is populated before updateEnv()

Two QtPassSettings calls remain in passbackendfactory.cpp (load + getPassStore);
removal of getGpgIdPath's QtPassSettings dependency is deferred to PR C.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: apply CodeRabbit auto-fixes

Fixed 2 file(s) based on 3 unresolved review comments.

Co-authored-by: CodeRabbit <noreply@coderabbit.ai>

* fix: address review findings on AppSettings injection

- keygendialog: pass getGpgExecutable() to getDefaultKeyTemplate() so
  gpgSupportsEd25519 uses the configured binary, not the "gpg" fallback
  (P1: silent regression on systems where gpg is GPG 1.x but user
  configured gpg2)
- QtPassSettings::load(): normalise passStore (absolutePath + trailing
  slash) so callers get a usable path without a separate getPassStore()
  override; SettingsSerializer::load() preserves raw stored value for
  round-trip fidelity (P2: duplicate override pattern removed)
- passbackendfactory: drop s.passStore = getPassStore() override; inline
  mkdir for first-run directory creation
- pass.cpp: fix clang-format violations (ColumnLimit=80 line breaks... (continued)

Coverage Stats

52 of 92 new or added lines in 6 files covered. (56.52%)

13 existing lines in 6 files now uncovered.

3990 of 6939 relevant lines covered (57.5%)

23.81 hits per line