IJHack / QtPass / 27652312625

57%

push

github

refactor(executor): replace QStringList env with QProcessEnvironment (#1510) (#1550)

* refactor(executor): replace QStringList env with QProcessEnvironment throughout

Resolves #1510. The blocking overload that accepted `QStringList env` and
internally parsed each `KEY=value` string into a `QProcessEnvironment` is
replaced by a clean `const QProcessEnvironment &env` parameter.

Changes:
- `Executor::executeBlocking`: `QStringList` env overload → `QProcessEnvironment`
- `Executor::setEnvironment` / `environment()`: same type switch
- `Pass::env` member: `QStringList` → `QProcessEnvironment`; constructor,
  WSLENV, macOS PATH, GNUPGHOME, and `setEnvVar` all updated to use
  `QProcessEnvironment::insert` / `remove` / `value`
- `ImitatePass::grepMatchFile` / `grepScanStore`: signatures updated
- `SshAuthSock`: removed `.toStringList()` round-trip
- `mainwindow.cpp`: use the two-arg no-input overload instead of passing
  explicit empty `QString()`
- Test suites (`tst_executor`, `tst_util`): updated to construct
  `QProcessEnvironment` via `insert()` instead of `KEY=value` string lists
- Remove now-unused `#include <algorithm>` from `pass.cpp`

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* style: clang-format fixes and restore full snapshot comparison in setEnvVarNoopOnMissingRemove

Fixes clang-format violations flagged by CI in mainwindow.cpp, pass.cpp,
sshauthsock.cpp, tst_executor.cpp, and tst_util.cpp.

Also restores the stronger pre/post snapshot QCOMPARE in
setEnvVarNoopOnMissingRemove: captures the full QProcessEnvironment before
calling setEnvVar with an empty value on a non-existent key, then compares
the snapshot to the environment after, catching any unexpected side effects
from env.remove() on a missing key.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(pass): exact PATH component check and safe prepend on macOS

Two issues in Pass::init() on macOS:
- `contains("/usr/local/bin")` matched substrings like `/usr... (continued)

19 of 22 new or added lines in 5 files covered. (86.36%)

3978 of 6921 relevant lines covered (57.48%)

31.71 hits per line