IJHack / QtPass / 27482110402

57%

push

github

refactor: migrate ConfigDialog to AppSettings load/save (#1511) (#1529)

* refactor: migrate ConfigDialog to AppSettings load/save (#1511)

Stage 2 of #1511. Replaces the constructor's per-getter widget loads and
on_accepted's per-setter writes with two focused methods:

- applySettings(const AppSettings&): loads the value widgets from the
  struct. The constructor now does load -> applySettings, then keeps the
  environment-dependent gating (tray/OTP/qrencode availability, clipboard
  combo population + primary-selection support) and the profile table.
- readSettings(): builds an AppSettings from the widgets, starting from the
  currently persisted settings so keys the dialog does not own (window
  geometry, WebDAV, profiles) are preserved on save. on_accepted now calls
  SettingsSerializer::save(readSettings()).

Behaviour preserved:
- usePass is re-applied via QtPassSettings::setUsePass after save so the
  cached Pass backend is still invalidated (the backend-lifecycle coupling
  is tracked for extraction in #1513 item 4).
- The SSH_AUTH_SOCK override validation warning, profile persistence and
  initializeNewProfiles() are unchanged.
- passStore is still normalised on save; password-generation and pwgen-path
  widgets are intentionally still not loaded at open, matching prior
  behaviour.
- addGPGId now defaults to true in AppSettings/SettingsSerializer, matching
  the effective default every isAddGPGId(true) call site already used.

All suites pass (settings 116, configdialog 16, full make check green).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix: preserve tray/close prefs when controls are disabled (#1511)

In ConfigDialog::readSettings the useTrayIcon, hideOnClose and
startMinimized values were saved as isEnabled() && isChecked(), so when
the system tray is unavailable the controls are disabled and the stored
preferences were overwritten to false. Now that readSettings starts from
the persisted settings, only overwrite each ... (continued)

40 of 89 new or added lines in 2 files covered. (44.94%)

3866 of 6857 relevant lines covered (56.38%)

35.94 hits per line