IJHack / QtPass / 27482393673

57%

push

github

refactor: extract Pass backend lifecycle into PassBackendFactory (#1513) (#1530)

Item 4 of #1513. QtPassSettings owned the active-backend dispatcher: the
static Pass*/RealPass/ImitatePass instances, getPass()/getRealPass()/
getImitatePass(), and the setUsePass() side-effect that reset the cached
backend. That is backend lifecycle, not settings storage.

Move all of it into a dedicated PassBackendFactory (src/passbackendfactory
.{h,cpp}):
- owns the three static instances and lazy construction,
- getPass() selects RealPass/ImitatePass from QtPassSettings::isUsePass()
  and initialises it once,
- invalidate() drops the active backend so the next getPass() re-selects.

QtPassSettings::getPass()/getRealPass()/getImitatePass() are now thin
forwarders (callers unchanged), and setUsePass() calls
PassBackendFactory::invalidate() instead of poking a private pointer. This
also removes the implicit coupling ConfigDialog had to work around in the
AppSettings migration (#1511 stage 2).

No behavioural change. make check green; doxygen and reuse clean.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

20 of 21 new or added lines in 2 files covered. (95.24%)

3873 of 6864 relevant lines covered (56.42%)

35.94 hits per line