IJHack / QtPass / 27480142055

57%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: introduce AppSettings struct + SettingsSerializer (#1511) (#1528)

First stage of the QtPassSettings boilerplate reduction (#1511). Adds the
foundation without touching existing behaviour:

- AppSettings (src/appsettings.h): a plain value object with one field per
  flat setting, carrying the same defaults the legacy getters apply
  (PasswordConfiguration length 16, clipBoardType NEVER, etc.). No QSettings
  dependency.
- SettingsSerializer (src/settingsserializer.{h,cpp}): pure, side-effect-free
  load()/save() between AppSettings and a QSettings store, using the exact
  same keys QtPassSettings uses so existing config files keep working.
  Unlike the old getters it performs no path normalisation, directory
  creation, screen-centring or .git auto-detection — those stay in the
  consumers.
- Tests in tst_settings: load-defaults, full save/load round-trip across
  every field, and key-compatibility against SettingsConstants.

Nested/keyed settings (profiles, per-dialog geometry, splitter positions)
are intentionally out of scope and still go through QtPassSettings; the
profile type is tracked separately. No existing getters are rewired yet —
that is staged in follow-up PRs (ConfigDialog, then other readers, then
deleting the wrappers). #1511 stays open.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Coverage Stats

132 of 133 new or added lines in 1 file covered. (99.25%)

292 existing lines in 3 files now uncovered.

3864 of 6853 relevant lines covered (56.38%)

36.36 hits per line