IJHack / QtPass / 27478339193

57%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: replace executeWrapper override with beforeExecute hook (#1513) (#1526)

The Pass execution path had a three-level dispatch: the 6-arg
executeWrapper was virtual purely so ImitatePass could prepend
transactionAdd(id) before delegating back to the base. That hid the
transaction wrapping inside an override of the dispatch function itself.

Make the 6-arg executeWrapper non-virtual and introduce an explicit
virtual beforeExecute(PROCESS) hook (no-op in the base) that it calls
right before dispatching to the Executor. ImitatePass now overrides only
that hook to register the transaction, so the wrapping is visible at the
call site and there is a single executeWrapper implementation.

No behavioural change: beforeExecute runs at exactly the point
transactionAdd previously did. All tests pass (incl. imitatepass +
integration).

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Coverage Stats

2 of 3 new or added lines in 2 files covered. (66.67%)

2 existing lines in 1 file now uncovered.

3732 of 6716 relevant lines covered (55.57%)

37.06 hits per line