IJHack / QtPass / 27478026925

57%

push

github

refactor: extract template I/O into TemplateIO module (#1514) (#1525)

* refactor: extract template I/O into TemplateIO module (#1514)

Move Util::readTemplates / writeTemplates / getFolderTemplate into a
dedicated TemplateIO class (src/templateio.{h,cpp}), completing the Util
grab-bag split. Template handling (the .templates INI file and per-folder
.default_template lookup) is a self-contained concern used only by the
add-password flow in MainWindow.

- Verbatim move of all three impls.
- Update the two MainWindow callers to TemplateIO::.
- Retarget the readTemplates*/writeTemplates*/getFolderTemplate* cases in
  tst_util to TemplateIO.
- Drop now-dead includes from util.cpp (QSaveFile, QTextStream,
  QStringConverter, algorithm).
- Wire templateio.cpp/.h into src/src.pro.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix: build on Qt 5.15 and check store boundary before file read

- Include <QDebug> in templateio.cpp: qWarning() needs the complete QDebug
  type, which Qt 6 pulled in transitively but Qt 5.15 does not, breaking
  the CI build.
- getFolderTemplate: move the store-boundary check to the top of the loop
  so paths resolving outside the store are rejected before any
  .default_template file is opened. The store root and its descendants are
  still probed (root read, then loop stops); only out-of-store paths are
  short-circuited.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

61 of 63 new or added lines in 2 files covered. (96.83%)

3735 of 6716 relevant lines covered (55.61%)

36.9 hits per line