IJHack / QtPass / 27477250065

57%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: extract isPathInStore into PathValidator module (#1514) (#1524)

* refactor: extract isPathInStore into PathValidator module (#1514)

Move Util::isPathInStore into a dedicated PathValidator class
(src/pathvalidator.{h,cpp}), continuing the Util grab-bag split.
The store-boundary check is a self-contained, security-sensitive
concern with no dependency on the rest of Util, so it earns its own
focused module.

- Verbatim move of the impl (walk to nearest existing ancestor,
  canonicalise, re-append leaf, compare against canonical store root).
- Update callers: StoreModel drag-drop (2 sites), MainWindow
  confirmPathInStore (1 site).
- Retarget the isPathInStore* cases in tst_util to PathValidator.
- Wire pathvalidator.cpp/.h into src/src.pro.

#1514 stays open for the remaining Template I/O slice
(readTemplates/writeTemplates/getFolderTemplate).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* l10n: fill empty unfinished translations flagged on review

Fill the empty <translation type="unfinished"> entries surfaced by the
qmake6 .ts refresh, keeping type="unfinished" so Weblate can refine.

- 10 locales (af, ar, bg, bn, ca, cs, de_DE, de_LU, el, en_GB): best-effort
  translations for the two new MainWindow strings "That name would resolve
  outside the password store..." and "Open %1 in browser", placeholders
  preserved. en_GB only lacked the latter.
- en_US: fill all 106 empty entries with the source text, converting British
  spellings (behaviour->behavior, etc.) and preserving %1/%2 placeholders.

All 11 files validated with lrelease6 (no errors/warnings).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Coverage Stats

24 of 26 new or added lines in 3 files covered. (92.31%)

9 existing lines in 1 file now uncovered.

3731 of 6714 relevant lines covered (55.57%)

36.9 hits per line