lsm / neokai / 27083825425

82%

push

github

feat: ACP protocol types + JSON-RPC stdio transport (#2074)

* feat(shared): add ACP protocol type definitions

Add ACP (Agent Client Protocol) JSON-RPC 2.0 type definitions:
- Base JSON-RPC types (request, response, notification, error)
- Initialization, authentication, session lifecycle
- Content blocks (text, image, audio, resource, resource_link)
- Session update notifications (agent chunks, tool calls, plan, mode, config)
- Tool call types with status tracking
- Permission request/response types
- File system and terminal operation types
- Config options and MCP server configurations
- Session modes

Barrel export at packages/shared/src/acp/index.ts, re-exported via mod.ts.

* fix(acp): align types and transport with ACP v1 spec

Address review feedback on PR #2074:

Types (packages/shared/src/acp/acp-types.ts):
- Rename initialize fields: clientCapabilities/agentCapabilities/agentInfo/authMethods
- Authenticate: methodId instead of credentials payload; empty result
- SessionNewResult: modes as optional { currentModeId, availableModes } state; configOptions optional
- SessionPromptParams: sessionId + prompt field
- StopReason: end_turn | max_tokens | max_turn_requests | refusal | cancelled
- Content blocks: image/audio use flat { mimeType, data, uri? } (not source wrapper)
- Session updates: use sessionUpdate discriminator in update payload
- Tool calls: toolCallId instead of id; ToolKind semantic categories (read/edit/create/delete/run_command/view/custom)
- Permissions: toolCall object + discriminated outcome (allow/deny/allow_once)
- FS: sessionId + line (1-based) instead of offset
- Terminal: sessionId, args, outputByteLimit
- ConfigOption: discriminated select type with grouped choices
- MCP stdio: env as EnvVariable[]; args required
- Add missing session types: close, load, resume, list, set_mode, set_config_option, logout
- Add _meta to all param/result types
- Remove duplicate AcpMode; keep AcpSessionMode

Transport (packages/daemon/src/l... (continued)

10124 of 14808 branches covered (68.37%)

Branch coverage included in aggregate %.

226 of 230 new or added lines in 3 files covered. (98.26%)

86664 of 101716 relevant lines covered (85.2%)

294.06 hits per line