lsm / neokai
82%

DEFAULT BRANCH: dev
Repo Added
Token jWzZooQL0w1AcfSmog6k6QC6pzcFMRtP7 regen
Build 8324 Last
Files 604
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH dev
branch: SELECT
CHANGE BRANCH
x
Sync Branches

coverage: 81.62% (+0.07%) from 81.554%
27590172818

push

github

web-flow 
fix: add DatabaseCredentialStore fallback when macOS Keychain unavailable (#2112)

* fix: add DatabaseCredentialStore fallback when macOS Keychain unavailable

When the daemon runs without GUI session access (SSH, CI, background launch,
locked keychain), `security` exits with code 36 (`errSecInteractionNotAllowed`).
Previously this crashed every provider credential load, marked providers
unhealthy, and spammed logs with stack traces — task sessions saw
"Not logged in" even when env var fallback would have worked.

Changes:
- KeychainCredentialStore: detect exit code 36 / "User interaction is not
  allowed" stderr and treat as "item not found" (return null) instead of
  throwing. `set()` swallows code 36 so callers can fall through.
- FallbackCredentialStore: new wrapper that tries the Keychain first and falls
  back to DatabaseCredentialStore on throw or missing item. `getStatus()`
  surfaces whether the primary is available.
- createCredentialStore() on darwin production now wraps Keychain in
  FallbackCredentialStore. Keychain remains the preferred primary.
- app.ts: skip marking provider unhealthy + skip stack-trace log on code 36
  (FallbackCredentialStore already returned null, so credentials load via
  env/settings fallback as before).
- Surface keychain-unavailable status through SystemState.credentialStore so
  the UI can warn the user. ProvidersSettings renders a yellow banner with
  the warning and the `security unlock-keychain` hint.

Tests:
- credential-store.test.ts: FallbackCredentialStore fallback, warn-once,
  listServices merge, delete best-effort, createCredentialStore wiring.
- credential-store-keychain.test.ts: KeychainCredentialStore exit-code-36
  handling via mocked `node:child_process` (uses dynamic import after
  mock.module registration so the live binding picks up the mock).

* fix: address review — throw on code 36 so fallback catches correctly

Addresses P0/P1/P2/P3 from PR #2112 review.

P0 — `KeychainCredentialStore.set(... (continued)

10489 of 15329 branches covered (68.43%)

Branch coverage included in aggregate %.

189 of 202 new or added lines in 10 files covered. (93.56%)

7 existing lines in 3 files now uncovered.

90044 of 107843 relevant lines covered (83.5%)

289.15 hits per line

Relevant lines Covered
107843 RELEVANT LINES 90044 COVERED LINES
289.15 HITS PER LINE
Source Files on dev

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
27590172818 dev fix: add DatabaseCredentialStore fallback when macOS Keychain unavailable (#2112) * fix: add DatabaseCredentialStore fallback when macOS Keychain unavailable When the daemon runs without GUI session access (SSH, CI, background launch, locked key... push web-flow github
81.62
27586211987 space/add-keychain-fallback-to-databasecredentialstore-when-macos Merge 98821f3a8 into d3043c649 Pull #2112 web-flow github
81.62
27585426659 space/add-keychain-fallback-to-databasecredentialstore-when-macos Merge 123f66a10 into d3043c649 Pull #2112 web-flow github
81.62
27585084213 codex/architecture-refactor-specs Merge eb325bac1 into d3043c649 Pull #1996 web-flow github
81.55
27584894067 space/add-keychain-fallback-to-databasecredentialstore-when-macos Merge 30c265cb0 into d3043c649 Pull #2112 web-flow github
81.62
27584166876 space/upgrade-claude-agent-sdk-from-0-2-141-to-0-3-175 Merge 690f773dd into d3043c649 Pull #2102 web-flow github
81.62
27568059738 space/upgrade-claude-agent-sdk-from-0-2-141-to-0-3-175 Merge f622b3ef6 into d3043c649 Pull #2102 web-flow github
81.61
27566911990 space/upgrade-claude-agent-sdk-from-0-2-141-to-0-3-175 Merge 158ecc86d into d3043c649 Pull #2102 web-flow github
81.61
27565124947 dev fix: align context window display + compaction for GLM/Kimi (#2113) * fix: align context window display + compaction for GLM/Kimi Two-layer fix for broken context window display and auto-compaction on non-native providers: Layer 1 (SDK configur... push web-flow github
81.55
27562104599 space/fix-context-window-display-compaction-for-glm-kimi-codex Merge 9bbcb130e into efed047a0 Pull #2113 web-flow github
81.56
See All Builds (3501)

Badge your Repo: neokai

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh