kobotoolbox / kpi / 27024834989

82%

master: 76%

push

github

fix(admin): fix timeout when viewing tokens DEV-2149 (#7119)

### 📣 Summary
Fix a timeout error when attempting to view individual user tokens in
Django admin.


### 💭 Notes
The built in TokenAdmin has `user` as an editable field, which requires
loading all users to create the selection dropdown. The PR makes the
`user` field read-only except on creation.
Since the original TokenAdmin is registered in DRF app code, we have to
unregister it before re-registering it with our edited version.


### 👀 Preview steps
Regression test only. Best to test with `--print-sql` running

1. ℹ️ have a superuser account
2. Go to django admin -> Auth Token -> Token
3. Select an arbitrary token to open the editing view
4. 🔴 [on release] notice there is a query that queries the entire
auth_user table (using a cursor)
5. :red_circle: [on release] notice you are able to change the user
6. 🟢 [on PR] notice all queries to auth_user are filtered
7. Delete the token
8. Create a new token for the same user
9. 🟢 Ensure new token is created successfully

9235 of 12470 branches covered (74.06%)

7 of 10 new or added lines in 1 file covered. (70.0%)

30498 of 37193 relevant lines covered (82.0%)

5.72 hits per line