kobotoolbox / kpi
82%
master: 76%

LAST BUILD BRANCH: main
DEFAULT BRANCH: master
Repo Added
Files 893
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x

coverage: 81.505% (+0.02%) from 81.49%
29316540845

push

github

web-flow 
fix(pairedData): return null source for deleted parent projects DEV-2034 (#7218)

### đŸ“Ŗ Summary
When a source project used for a connected (paired) dataset is deleted,
it is now clearly reported as deleted rather than still appearing as a
normal source.

### 📖 Description
Connected projects pull data from a "source" project. If that source
project was deleted, the paired-data endpoint kept listing it as if it
were a live source, which the connected-projects UI couldn't reliably
detect. The deleted source's `source` link is now returned as `null`,
giving the frontend a dependable signal.

### 💭 Notes
`paired_data` is stored as a JSON blob on the destination `Asset` keyed
by source uid, with **no cascading FK**, so deleting a source asset
leaves a dangling reference (DEV-2034).
`PairedDataSerializer.to_representation` now emits `source: null` when
the source Asset row no longer exists, detected by reusing the
`source__names` mapping the viewset already builds (uid absent ⇒ row
deleted) — no extra query on the list endpoint, with a direct
`.exists()` fallback when context is absent. Runtime-only change: no
OpenAPI schema drift, no migration.

### 👀 Preview steps
1. ℹī¸ have an account with two projects; enable data sharing on project
**A** (the source).
2. Connect project **B** to **A** (paired data) and `GET
/api/v2/assets/<B_uid>/paired-data/`.
3. Delete project **A**.
4. `GET /api/v2/assets/<B_uid>/paired-data/` again.
5. 🔴 [on main] the deleted source still appears with a populated
`"source"` URL (only `"source__name"` is null).
6. đŸŸĸ [on PR] that entry's `"source"` is `null`.

9329 of 12655 branches covered (73.72%)

4 of 12 new or added lines in 1 file covered. (33.33%)

237 existing lines in 5 files now uncovered.

30346 of 37232 relevant lines covered (81.51%)

5.52 hits per line

Relevant lines Covered
37232 RELEVANT LINES 30346 COVERED LINES
5.52 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
29316540845 main fix(pairedData): return null source for deleted parent projects DEV-2034 (#7218) ### đŸ“Ŗ Summary When a source project used for a connected (paired) dataset is deleted, it is now clearly reported as deleted rather than still appearing as a normal s... push web-flow github
81.51
29316127474 hugo/dev-1976-constance-env-prefix Merge 078be154f into c014d04db Pull #7230 web-flow github
50.39
29313991722 hugo/dev-1833-asset-permissions-single-fetch Merge af469e7f2 into c014d04db Pull #7238 web-flow github
49.6
29313369639 hugo/dev-1856-form-title-long-filename-500 Merge 9b862e7cc into c014d04db Pull #7234 web-flow github
44.45
29289350696 dev-2417-q-search-allowlist Merge 64d7a9237 into 463d41633 Pull #7243 web-flow github
81.38
29287541794 dev-2417-q-search-allowlist Merge df49afa65 into 463d41633 Pull #7243 web-flow github
80.37
29283215637 dev-2417-q-search-allowlist Merge c980ea56b into 463d41633 Pull #7243 web-flow github
81.38
29280399348 dev-2417-q-search-allowlist Merge 135e49883 into 463d41633 Pull #7243 web-flow github
77.35
29277404776 dev-2417-q-search-allowlist Merge 11d4dad84 into 463d41633 Pull #7243 web-flow github
61.36
29277110699 dev-2417-q-search-allowlist Merge a081877b3 into 463d41633 Pull #7243 web-flow github
61.36
See All Builds (12955)