kobotoolbox / kpi / 27147750209

82%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

fix(accounts): avoid IntegrityError on SSO reconnect DEV-2226 (#7126)

### 📣 Summary

Reconnecting a social (SSO) account failed with a database error when
the user's email address was already stored.

### 💭 Notes

- The crash occurred in `update_email` (signal on
`social_account_added`) at `primary.set_as_primary()`, which called
`save()` on an unsaved `EmailAddress` instance — triggering an INSERT
that violated the `unique(user_id, email)` constraint.
- Fix: before calling `set_as_primary()`, if `primary.pk` is `None`, we
attempt `EmailAddress.objects.get(user=social_user,
email=primary.email)`. If the row already exists, we reuse that instance
(with its pk) so `save()` does an UPDATE instead of INSERT.
- The lookup is scoped to `user=social_user`, so two users sharing the
same email address cannot interfere with each other.
- Two new tests cover: (1) reconnecting SSO with an already-stored
email, (2) isolation between users who share an email.

Coverage Stats

9236 of 12472 branches covered (74.05%)

0 of 5 new or added lines in 1 file covered. (0.0%)

519 existing lines in 20 files now uncovered.

30503 of 37198 relevant lines covered (82.0%)

5.72 hits per line