kobotoolbox / kpi / 26639973323

82%

master: 76%

push

github

fix(admin): fix adding users in Django Admin DEV-2180 (#7096)

### 📣 Summary
Fixes a bug in Django admin that was preventing admins from adding
users.

### 💭 Notes
The Django 5 upgrade introduced a new concept of `usable_password`,
which is a setting that can allow/forbid users to authenticate with a
password (as opposed to SSO or LDAP or something). This field is
included by default in the UserAdmin, but not present on the model.
Instead, it is created by a mixin that is present in
`AdminUserCreationForm` but not regular `UserCreationForm.`
The solution is to update our `UserCreationForm` to use
`AdminCreationUserForm` as a base and just hide the `usable_password`
field by overriding the `fieldsets`.


### 👀 Preview steps

1. ℹ️ have a superuser account
2. Go to Django admin -> Users
3. Add user
4. 🔴 [on release] 500
5. 🟢 [on PR] you are able to successfully add a new user

9237 of 12469 branches covered (74.08%)

4 of 6 new or added lines in 1 file covered. (66.67%)

30492 of 37183 relevant lines covered (82.01%)

5.72 hits per line