MushroomObserver / mushroom-observer / 26946735949

98%

push

github

ERB→Phlex: alt_descriptions panel + Descriptions::List view (#4437)

Three new Phlex views replace the two `_alt_descriptions_panel.html.erb`
partials and the inline iteration code they shared:

- `Views::Controllers::Descriptions::List` — renders the visible
  descriptions for a Name or Location as either `<div>`-wrapped
  items (default, matches the pre-Phlex names partial) or
  `<br>`-separated items (`separator: :br`, matches the locations
  partial's `safe_join(safe_br)` shape). Wraps the existing
  `DescriptionsHelper#list_descriptions` helper as a registered
  value-helper rather than re-implementing the filter / sort /
  link / mod-link chain inline — that chain composes 5+ helper
  methods (`reviewer?`, `in_admin_mode?`, `sort_description_list`,
  `make_list_links`, `DescriptionIconsHelper#description_mod_links`,
  etc.); per `.claude/rules/phlex_conversions.md`, helpers that
  themselves compose other helpers stay registered for now.
- `Views::Controllers::Names::Show::AltDescriptionsPanel` — panel
  chrome (Panel + create-description icon-link + empty-state
  message) rendering the List view.
- `Views::Controllers::Locations::Show::AltDescriptionsPanel` —
  same shape, plus the optional "create draft for project" row at
  the bottom when callers pass a `projects:` array. Uses `:br`
  separator to preserve the locations partial's pre-Phlex DOM.

Both show ERBs (`names/show.html.erb`, `locations/show.html.erb`)
switch from `render(partial: ...)` to
`render(Views::Controllers::...::AltDescriptionsPanel.new(...))`.

The two `_alt_descriptions_panel.html.erb` partials are deleted.
`list_descriptions` stays in `descriptions_helper.rb` (still called
internally by `Views::Controllers::Descriptions::List` and by
`tabs/observations_helper.rb#obs_name_description_tabs` until those
callers' parent contexts migrate to Phlex too).

5 component tests cover `Descriptions::List`'s div/br separator
modes and the empty-text fallback.

Co-authored-by: Claude O... (continued)

67 of 67 new or added lines in 3 files covered. (100.0%)

42287 of 43594 relevant lines covered (97.0%)

688.52 hits per line