MushroomObserver / mushroom-observer / 26950798156
98%

DEFAULT BRANCH: main
Ran
Jobs 0
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
26950798156

push

github

web-flow 
Descriptions::List: inline list_descriptions, drop helper registration (#4438)

* Descriptions::List: inline list_descriptions, drop helper registration

The PR that introduced `Views::Controllers::Descriptions::List`
(#4437) shipped with `register_value_helper :list_descriptions`
— defeating the refactor's premise (helpers are what we're
eliminating, not perpetuating). Inline the full
`list_descriptions` + `sort_description_list` + `make_list_links`
+ `description_link` + `description_title` +
`description_mod_links` chain as private methods on the view.

`list_descriptions` still exists in `descriptions_helper.rb` for
its last remaining caller
(`tabs/observations_helper.rb#obs_name_description_tabs`); the
helper chain dies when `_name_info.erb` migrates to Phlex too.

Other cleanups in the same PR:

- Drop the locations panel's `:br` `separator:` arg from
  `Descriptions::List`. The visual outcome of `<div>`-wrapped vs
  `<br>`-joined items is identical, so standardize on `<div>`
  (names panel's existing shape). The `separator:` prop goes away.
- Drop the `INDENT = '<span class="ml-3">&nbsp;</span>'.html_safe`
  pattern in both the descriptions list (mod-links indent) and the
  locations panel (per-project indent). Wrap the content in a
  `<span class="ml-3">` directly — class-based margin on the actual
  content, not a `<nbsp>` filler span.
- Add `register_value_helper :in_admin_mode?` to `Views::Base` so
  the request-context predicate is reachable from all
  `Views::Controllers::*` views, not only `Components::ApplicationForm`
  descendants. Matches `register_value_helper :permission?` on
  `Components::Base`.
- Register `reviewer?` only on `Views::Controllers::Descriptions::List`
  — it's a description-domain predicate (gates visibility of
  restricted descriptions for reviewers-group users), so it stays
  scoped to its consumer rather than going on `Views::Base`.

Also add a new hard rule to
`.claude/rules/phlex_conversions.md`: `register_valu... (continued)
Source Files on build 26950798156
Detailed source file information is not available for this build.