MushroomObserver / mushroom-observer / 26946666492

98%

push

github

ERB→Phlex: observations/namings/{new,edit} (#4434)

* ERB→Phlex: observations/namings/{new,edit}

Convert the "propose a name" / "edit a naming" pages to Phlex.
The pre-conversion ERBs were nearly identical 41-line two-column
layouts wrapping the existing `Views::Controllers::Observations::
Namings::Form` Phlex component; differed only in the page title
helper they called (`naming_form_new_title` /
`naming_form_edit_title`).

Two new Phlex views, both inheriting `Views::Base`, with the title
inlined as a private `.t(id:)` lookup:

- `Views::Controllers::Observations::Namings::New`
- `Views::Controllers::Observations::Namings::Edit`

Controller changes (`Observations::NamingsController`):

- `new` and `edit` actions' `format.html` block now explicitly
  renders the Phlex view with `layout: true` (the shared
  `build_index_with_query`-style implicit render doesn't apply here
  — straight `format.html { render(...) }` works).
- `respond_to_form_errors` (used by create/update validation
  failures to re-render the form) routes to the matching Phlex view.
- `modal_title` inlines the same `:create_naming_title.t` /
  `:edit_naming_title.t` lookups that the deleted helpers wrapped.

Helper cleanup:

- `tabs/observations_helper.rb` — delete `naming_form_new_title`
  and `naming_form_edit_title` (their only callers were the now-
  deleted ERBs + the controller, which inlines them).
- Down to 6 methods in `tabs/observations_helper.rb`: the 3 HTML
  composers blocked on `descriptions_helper#list_descriptions`
  migrating, `observations_index_sorts` blocked on the obs index
  ERB→Phlex conversion, and `obs_details_links` /
  `print_labels_button` blocked on the obs show ERB→Phlex
  conversion.

Test fix: `assert_edit` previously used `assert_template
("observations/namings/edit")` to confirm the edit page rendered
after a failed update. Phlex views render outside the ActionView
template lookup chain, and the body class is unreliable here too
(failed `update` re-r... (continued)

71 of 71 new or added lines in 3 files covered. (100.0%)

42220 of 43527 relevant lines covered (97.0%)

682.53 hits per line