MushroomObserver / mushroom-observer / 26921827875

98%

push

github

Relocate *_index_sorts; delete tabs/{locations,names}_helper.rb (#4432)

* Relocate *_index_sorts; delete tabs/{locations,names}_helper.rb

`locations_index_sorts` and `names_index_sorts` were the only
methods left in `tabs/locations_helper.rb` and `tabs/names_helper.rb`
— both non-tab utilities (sort options for `add_sorter`). Move
them to the corresponding `app/helpers/{locations,names}_helper.rb`
and delete the now-empty tabs/* files. Rails auto-helper inclusion
keeps the methods reachable from every consuming ERB without further
wiring.

Tidy up dangling `# Replaces Tabs::{Locations,Names}Helper#...`
docstring lines in 5 Tab POROs whose original helper-method
counterparts no longer exist.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Fix dead rss_log branch in *_index_sorts predicates

The pre-existing rss_log branch in `locations_index_sorts` /
`names_index_sorts` / `species_lists_index_sorts` / the Phlex
`Views::Controllers::SpeciesLists::Index#sort_options` compared
`query.params[:order_by]` against the Symbol `:rss_log`. But
`Query.lookup(...)` stores `order_by` as a String value
("rss_log") — the comparison was always false and the rss_log
branch never fired. The "Updated" sort link always pointed at
`updated_at`, even when the active query was rss_log-ordered.

Fix the comparison to use the String "rss_log" so the documented
behavior takes effect — when a user is on an rss_log-ordered
index, "Updated" now sorts by the rss_log timestamp instead.

Add `LocationsHelperTest` + 3 `NamesHelperTest` cases that pin
both branches.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Coverage: add integration test that hits rss_log-branch of LocationsHelper

The helper-level rss_log test in test/helpers/locations_helper_test.rb
covers the branch in unit-test workers, but its coverage isn't
reflected in coveralls' merged build (the parallel-worker upload
race we've seen before). Add a controller-level inte... (continued)

10 of 10 new or added lines in 4 files covered. (100.0%)

42159 of 43472 relevant lines covered (96.98%)

681.6 hits per line