MushroomObserver / mushroom-observer / 26840638044

97%

push

github

Tab POROs: 5 small action-nav helpers + delete general_helper (#4425)

Converts the last 4 small action-nav helpers (admin, user_nav, emails,
authors) and finishes off tabs/general_helper.rb by inlining its
remaining 2 callers (tabs/projects_helper.rb tab methods + 2 ERB views).

Tab::Admin::* (1 single + 2 Collections)

- CreateDonation
- DonationsFormNew, DonationsFormEdit

Tab::UserNav::* (2 single + 2 Collections)

- AdminMode (toggles on/off via in_admin_mode flag), Logout
- LoggedIn (7 tabs composing User + Account POROs), LogOut (admin
  mode + optional logout)

Tab::Email::* (2 Collections)

- NameChangeRequest, MergeRequest — both [Tab::Object::Return]
  variants

Tab::Description::AuthorReview (Collection)

Replaces the standalone tabs/authors_helper.rb (one method,
authors_helper#author_review_tabs). Composes Tab::Object::ShowParent
+ Tab::Object::Show.

general_helper deletion

The 6 polymorphic helper methods (object_return_tab, show_object_tab,
show_parent_tab, object_index_tab, search_tab_for, external_search_urls)
were thin delegators to Tab::Object::* / Tab::ExternalSearch — already
fully POROd. Updated the 2 remaining callers (tabs/projects_helper.rb
member-form tab methods + species_lists/downloads/new.rb +
glossary_terms/show.html.erb) to use the POROs directly, then deleted
the helper file.

projects_helper note

`project_members_form_new_tabs` + `project_member_form_edit_tabs`
are the last Tab-style methods in projects_helper. The rest of the
file (project_button family, projects_index_sorts, add_project_banner)
stays — they're not tab definitions and don't migrate to POROs.

Caller updates

- 2 admin/donations ERB views → Tab::Admin::Donations*
- 2 admin/emails ERB views → Tab::Email::*
- descriptions/authors/show.html.erb → Tab::Description::AuthorReview
- application/top_nav/_user_nav.html.erb → Tab::UserNav::Logged*
- species_lists/downloads/new.rb → Tab::Object::Return
- glossary_terms/show.html.erb → Tab::ExternalSearch

Te... (continued)

74 of 74 new or added lines in 12 files covered. (100.0%)

42053 of 43387 relevant lines covered (96.93%)

665.92 hits per line