MushroomObserver / mushroom-observer / 26837770347

97%

push

github

Tab POROs: users + account + checklists batch (#4423)

* Tab POROs: users + account + checklists batch

Converts the cross-domain users + account + checklists triad in one
batch. Closes the cross-helper dependencies between users_helper +
account_helper + sidebar/user_helper + user_nav_helper + checklists_helper.

Tab::Account::* (7 single + 3 Collections)

- EditPreferences (carried over from prior batch), EditProfile,
  BulkLicenseUpdater, ShowNotifications, ShowInterests, ShowAPIKeys,
  ChangeImageVoteAnonymity
- ProfileEditActions / PreferencesEditActions / APIActions Collections
- Zeitwerk: ShowAPIKeys + APIActions follow the registered `API`
  acronym (config/initializers/inflections.rb)
- account_welcome_title moved to top-level AccountHelper

Tab::User::* (8 single + 2 Collections)

- Observations, Profile, Summary, CommentsFor, LifeList,
  EmailQuestion, AdminChangeBonuses, AdminDestroy
- ProfileActions Collection (self-view / other-view branches with
  admin-append toggle)
- ShowActions Collection ([Tab::Contributor::Index])
- users_index_sorts (+ regular_/admin_ variants) moved to top-level
  UsersHelper

Tab::Checklist::ShowActions (Collection)

Three-branch composition (user / list / site-wide). Carried over
from the prior batch where this was deferred because users_helper
wasn't ready yet. Tab::Checklist::SiteList (added in the prior batch
for the info/site_stats action-nav) stays.

Cross-helper rewires (helpers stay; their callers swap to POROs)

- sidebar/user_helper#sidebar_user_tabs composes Tab::User::* +
  Tab::Account::* directly
- user_nav_helper#user_logged_in_tabs composes Tab::User::* +
  Tab::Account::* directly
- app/views/layouts/sidebar/user.rb (Phlex) drops the now-broken
  `include Tabs::AccountHelper` / `include Tabs::UsersHelper`

Caller updates

- users/show.html.erb: add_context_nav(Tab::User::ShowActions.new)
- users/show/_profile.erb: ProfileActions Collection + EmailQuestion
- account/api_keys/{index,edit,new}.htm... (continued)

188 of 188 new or added lines in 26 files covered. (100.0%)

42033 of 43369 relevant lines covered (96.92%)

664.16 hits per line