MushroomObserver / mushroom-observer / 26886934039

97%

push

github

Tab POROs: sidebar batch (8 helpers, ~37 POROs) (#4427)

* Tab POROs: sidebar batch (8 helpers, ~38 POROs)

Converts all 8 tabs/sidebar/*.rb files to Tab::Sidebar::* POROs.
Drops the explicit Tabs::Sidebar::*Helper includes from
Views::Layouts::ApplicationSidebar and Views::Layouts::Sidebar::User,
and replaces the sidebar_*_tabs(...) calls with Tab Collections.

Per-domain POROs (37 single tabs + 8 Collections)

- Tab::Sidebar::Admin::{Jobs, BlockedIps, SwitchUsers, Users, Banners,
  Licenses} + AdminActions Collection (admin-only top section)
- Tab::Sidebar::{Login, Signup} + LoginActions Collection (logged-out
  top section)
- Tab::Sidebar::Indexes::{Glossary, Herbaria, Locations, Names,
  Projects} + IndexesActions Collection (user-only)
- Tab::Sidebar::Info::{MobileApp, Intro, HowToUse, Donate,
  HowToHelp, ReportABug, SendAComment, Contributors, SiteStats,
  TranslatorsNote, Publications, PrivacyPolicy} + InfoActions
- Tab::Sidebar::Latest::{News, Changes, Images, Comments} +
  LatestActions Collection (News always shown; rest user-only)
- Tab::Sidebar::Observations::{Latest, New, Yours, Identify} +
  ObservationsActions Collection (Latest always shown; rest user-only)
- Tab::Sidebar::SpeciesLists::{Yours, All, New} +
  SpeciesListsActions Collection (user-only)
- Tab::Sidebar::User::JoinMailingList + UserActions Collection
  (mobile-only sidebar user section; composes Tab::User::* +
  Tab::Account::* + the mailing-list tab)

Dead code dropped

- nav_qr_code_tab (tabs/sidebar/observations_helper.rb) — defined
  but never composed into sidebar_observations_tabs and not called
  anywhere else.

ApplicationSidebar refactor

Inlined `render_section` helper to keep `render_info_sections`
under Metrics/AbcSize after the Tab Collection insertions.
Sidebar/User view's `render_tabs` switched from `.compact.each` to
`.filter_map(&:to_a).each` (rubocop autocorrect; semantically
identical since Tab::Base#to_a never returns nil).

Tests

11 collection composi... (continued)

331 of 331 new or added lines in 49 files covered. (100.0%)

42241 of 43573 relevant lines covered (96.94%)

671.92 hits per line