MushroomObserver / mushroom-observer / 26833760340

97%

push

github

Tab POROs: 12 small action-nav helpers (the big one with field slips) (#4421)

* Tab POROs: 12 small action-nav helpers (field_slips + the rest)

Converts 12 small/independent action-nav helpers to Tab POROs in one
batch. Originally planned for 13 — `tabs/checklists_helper.rb` was
deferred to the users+account batch because its `checklist_for_user_tabs`
composes user_profile_tab / user_observations_tab / email_user_question_tab
from `tabs/users_helper.rb`, which isn't ready yet.

Converted domains (40+ Tab POROs across them)

- field_slips    (3 single + 2 collections)
- external_links (2 single)
- namings        (2 single)
- themes         (1 single + 1 collection)
- rss_logs       (1 single + 1 collection)
- inat_imports   (1 single + 1 collection)
- contributors   (1 single + 1 collection)
- info           (1 single + 1 collection)
- publications   (2 single + 3 collections)
- articles       (2 single + 3 collections; index gated on can_edit?)
- support        (4 single + 3 collections; admin flag toggles append)
- licenses       (4 single + 4 collections; show toggles destroy on in_use?)

Plus 1 PORO each carved out of next-batch domains to support cross-deps:
- Tab::Account::EditPreferences — composed by theme show
- Tab::Checklist::SiteList — composed by info site_stats

Dead code dropped

- tabs/inat_helper.rb was an empty module — deleted outright
- field_slips: 4 dead helper methods (destroy_field_slip_tab,
  edit_field_slip_tab; only the 2 single tabs the Collection
  composes are POROs now)

Non-tab utilities relocated

- license_show_title / license_edit_title / license_title_id moved to
  the existing top-level LicensesHelper
- articles_index_sorts → new top-level ArticlesHelper

Cross-helper rewires (in this batch, not yet POROs themselves)

- tabs/users_helper.rb `user_show_tabs` now composes
  `Tab::Contributor::Index` directly (was site_contributors_tab)
- tabs/checklists_helper.rb `checklist_for_site_tabs` now composes
  Tab::Contrib... (continued)

329 of 329 new or added lines in 53 files covered. (100.0%)

41936 of 43273 relevant lines covered (96.91%)

661.37 hits per line