MushroomObserver / mushroom-observer / 26790746995

97%

push

github

Tab POROs: convert descriptions (10 single Tabs + helper cleanup) (#4416)

* Tab POROs: convert descriptions (10 single Tabs + helper cleanup)

Converts `tabs/descriptions_helper.rb` to 10 `Tab::Description::*`
single-tab POROs and deletes 3 helper files
(`tabs/descriptions_helper.rb` + `tabs/names/descriptions_helper.rb` +
`tabs/locations/descriptions_helper.rb`). Closes out the
descriptions side of the names/locations work that landed in #4411
and #4412.

10 single Tab POROs under Tab::Description::*

- Create, Edit, Clone, Merge, Move, AdjustPermissions, MakeDefault,
  Project, PublishDraft, NewForProject.

Each derives `type` (`:name`/`:location`) from the description's
parent — callers no longer pass it explicitly. Permission checks
(admin / writer / public-source / draft-status) move into the
calling helpers, not the POROs themselves.

Tab::NameDescription::FormEdit absorbs AdjustPermissions

The form_edit Collection now accepts `admin:` and appends
Tab::Description::AdjustPermissions when set. The ERB caller
(`names/descriptions/edit.html.erb`) computes
`@description.is_admin?(@user) || in_admin_mode?` and passes it in.
Replaces the helper-delegator append that previously lived in
`tabs/names/descriptions_helper.rb`.

Icon-link strip extracted

`description_change_links` (the inline Edit / Destroy / Clone /
Move / Merge / Adjust / MakeDefault / Project / Publish strip
shown in description panel headings) moves to a new top-level
`DescriptionIconsHelper` (`app/helpers/description_icons_helper.rb`)
along with the 6 supporting per-icon helpers. Kept as a helper
rather than a Collection because it composes `edit_button` /
`destroy_button` (which are not tabs) alongside tab POROs and
renders inline HTML, not a context-nav menu. New module so
`DescriptionsHelper` itself stays under the Metrics/ModuleLength
limit.

`descriptions_index_sorts` moves to top-level `DescriptionsHelper`
(used by both `names/descriptions/index.html.erb` and
`locations/descri... (continued)

173 of 173 new or added lines in 13 files covered. (100.0%)

41432 of 42798 relevant lines covered (96.81%)

669.51 hits per line