MushroomObserver / mushroom-observer / 26790704702

97%

push

github

Tab POROs: convert glossary_terms (3 single Tabs + 4 Collections) (#4415)

Converts `tabs/glossary_terms_helper.rb` to Tab POROs and deletes
the helper file. Smallest standalone domain remaining from the
original PR 2 cluster (61 LOC).

3 single Tab POROs under Tab::GlossaryTerm::*

- Show  — :show_glossary_term.t(glossary_term: …) (carries term
          name in the title, distinct from Tab::Object::Show)
- Index — :glossary_term_index.t (distinct title from
          Tab::Object::Index)
- Edit  — :edit_glossary_term.t

The "cancel and return" tab uses Tab::Object::Return directly —
the title produced by Tab::Object::Return.new(object: term)
(`:cancel_and_show.t(type: :glossary_term)`) matches the original
helper exactly, including the `glossary_term_return_link` html
class.

4 Tab::Collection subclasses

- FormNew        — [Index]
- FormEdit       — [Object::Return(term), Index]
- ImageForm      — [Object::Return(term), Edit]  (images/reuse +
                   images/remove)
- VersionActions — [Show]

Caller updates

- glossary_terms/edit.html.erb
- glossary_terms/new.html.erb
- glossary_terms/images/remove.html.erb
- glossary_terms/images/reuse.html.erb
- glossary_terms/versions/show.html.erb

Tests

7 tests / 20 assertions across the new test/classes/tab/glossary_term/
files (single Tab POROs verify title / path via route helpers /
html_options; Collections pin composition order).

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

52 of 52 new or added lines in 7 files covered. (100.0%)

41348 of 42724 relevant lines covered (96.78%)

673.63 hits per line