MushroomObserver / mushroom-observer / 26791335673

97%

Build Type

push

github

Committed by web-flow

Commit Message

Tab POROs: bundle (comments, collection_numbers, herbarium_records, sequences, images) (#4417)

* Tab POROs: bundle (comments, collection_numbers, herbarium_records, sequences, images)

Converts 5 small/action-nav helpers to Tab POROs in one batch.
Independent of the descriptions / glossary_terms branches — only
depends on Tab::Object::*, Tab::Herbarium::*, and Tab::Related::Query
(all in main).

Tab::Comment::* (4 single + 3 Collections)

- New, Edit, Destroy single tabs
- FormNew, FormEdit, ShowActions Collections
- comments_controller's modal_title inlines `:comment_*_title.t`
  directly (was helper-delegating); comments_helper.rb (top-level)
  now owns comments_index_sorts and uses Tab::Comment::New from
  `new_comment_link`.

Tab::CollectionNumber::* (5 single + 3 Collections)

- Show, New, Edit, Destroy, BackToIndex single tabs
- IndexActions, FormNew, FormEdit Collections
- New top-level CollectionNumbersHelper owns collection_numbers_index_sorts
  and remove_collection_number_button (non-tab helpers).

Tab::HerbariumRecord::* (4 single + 4 Collections)

- Show, New, Edit, BackToIndex single tabs
- IndexActions, ShowActions, FormNew, FormEdit Collections
- New top-level HerbariumRecordsHelper owns herbarium_records_index_sorts
  and remove_herbarium_record_button.

Tab::Sequence::* (7 single + 2 Collections)

- Show, New, Edit, EditAndBack, Destroy, Archive, Blast single tabs
- ShowActions, Form Collections
- sequences_helper.rb (top-level) gains sequences_index_sorts.

Tab::Image::* (6 single + 3 Collections)

- Edit, Destroy, Eol, CommercialInquiry, NameGoogleImages, TestAgain
  single tabs
- ShowActions, IndexActions, EXIFShow Collections
- The image show page's "Google Images by name" link uses
  Tab::Image::NameGoogleImages (searches by name.search_name, plain
  InternalLink), distinct from Tab::Name::UserGoogleImages
  (user-aware, uses name.user_real_text_name).
- images_helper.rb (top-level) gains images_index_sorts.
- Zeitwerk note: Ta... (continued)

Coverage Stats

456 of 456 new or added lines in 46 files covered. (100.0%)

1 existing line in 1 file now uncovered.

41750 of 43106 relevant lines covered (96.85%)

666.98 hits per line