MushroomObserver / mushroom-observer / 26789689542

97%

push

github

Coverage gaps: delete dead form/panel helpers, fix Herbarium#order_by_user (#4419)

Closes the largest non-Tab coverage regressions flagged by coveralls.
Same dead-delegator pattern as the Tab POROs PR: most of the gap is
unreachable helper methods that lost callers without being deleted.

forms_helper.rb (-61 missing diff)

Delete 6 public helpers with zero production callers (verified
across app/ + test/):
- check_button_with_label
- radio_button_with_label
- date_select_with_label
- read_only_field_with_label
- static_text_with_label
- url_field_with_label

Delete their internal-only date helpers transitively
(date_field_inputs_div / day_select / month_select / year_input
/ param_name / selected_value — 6 more methods, only called from
the deleted date_select_with_label).

panel_helper.rb (-8 missing diff)

Simplify two helpers to the shape callers actually use:
- help_block_with_arrow: drop the `mobile:` knob (no production
  caller passes it — the arrow is always xs-hidden). Combined
  branch keeps the only two real shapes (direction + no-direction).
- collapse_help_block: drop direction handling and the string-
  argument form (only one production caller, passes block + no
  direction). Updated the caller in forms_helper.rb to match the
  slimmed signature.

Herbarium#order_by_user fix (-6 missing diff, was a broken override)

The original PR (#4414) defined `scope :order_by_user, lambda { ... }`,
but AbstractModel's Query dispatcher checks
`model.private_methods(false).include?(:order_by_user)` — public
scopes don't match, so the override silently fell through to "all
herbaria, no order." Moved to a private class method via
`class << self; private; def order_by_user; ...; end; end`.
Added `Query::HerbariaTest#test_herbarium_order_by_user` pinning
the scope works.

CrudButton::Edit String-target default name

Added test_edit_button_string_target_default_name — exercises the
`default_name` branch where target.is_a?(String) returns `:EDIT.l`
(dist... (continued)

6 of 9 new or added lines in 3 files covered. (66.67%)

41314 of 42690 relevant lines covered (96.78%)

674.05 hits per line