MushroomObserver / mushroom-observer / 26789686984

97%

push

github

Tab POROs: close coverage gaps (delete dead delegators + cover edge cases) (#4418)

Closes Tab-related coverage regressions flagged by coveralls. Most of
the regression is dead helper-delegator methods that became
unreachable when downstream callers switched to consuming
Collections directly; deleting them is the right fix.

Dead helper-method deletions (19 total)

- tabs/locations_helper.rb (7): new_location_tab, map_locations_tab,
  location_countries_tab, edit_location_tab,
  location_new_description_tab, location_versions_tab,
  locations_index_tab
- tabs/observations_helper.rb (9): observations_of_name_tab,
  observations_of_look_alikes_tab, observations_of_related_taxa_tab,
  map_observations_tab, observations_add_to_list_tab,
  observations_download_as_csv_tab, observations_index_tab,
  edit_observation_tab, new_inat_import_tab
- tabs/names_helper.rb (2): new_name_tab, all_names_tab
- tabs/related_objects_helper.rb (1): related_names_tab

These all had zero callers (verified via `grep -rn METHOD app/` with
the helper file excluded and same-file calls audited). Each was a
1-line delegator to a Tab PORO that's still composed by a Collection;
the Tab POROs stay live.

Dead Tab PORO deletion (1)

Tab::Location::NewDescription — paired with the deleted
`location_new_description_tab`. The location show page's alt-
descriptions panel uses the generic polymorphic
`create_description_tab(object, type)` from
`tabs/descriptions_helper.rb`, not the location-specific variant.

Tab::Related::Query refactor

`title`, `path`, `html_options` methods were dead because
`to_internal_link` is overridden to return the cached
`InternalLink::RelatedQuery` directly — so the inherited Tab::Base
path never calls them. Deleted; collapsed `internal_link` private
method into `to_internal_link` (renamed memoized ivar to match).

Tab::Base + Tab::Collection abstract-method tests

Added base_test.rb + collection_test.rb covering the
NotImplementedError branches on `#title` / `... (continued)

1 of 1 new or added line in 1 file covered. (100.0%)

41325 of 42776 relevant lines covered (96.61%)

669.36 hits per line