MushroomObserver / mushroom-observer / 26757146128

97%

push

github

Cleanup: delete tabs/species_lists_helper.rb + tabs/herbaria_helper.rb (#4414)

`tabs/species_lists_helper.rb` and `tabs/herbaria_helper.rb` had been slimmed in #4405 and #4408 down to a couple of cross-domain composers + sort utilities; now that the leaves PR (#4409) shipped `Tab::Object::Return`, the cross-domain methods can also become Tab::Collection POROs and both helper files can go entirely.

2 new Tab::Collection POROs under Tab::SpeciesList::*

- FormEdit         — [Object::Return(list), Upload(list)]
- FormEditProject  — [Object::Return(list)]

Sort utilities relocated

- species_lists Phlex index inlines into a private sort_options method;
  the remaining ERB caller (observations/species_lists/edit.html.erb)
  goes through a slim top-level SpeciesListsHelper. Helper goes away
  once the rest of the species_lists domain converts to Phlex.
- herbaria sort options stay as a top-level HerbariaHelper since
  herbaria/index.html.erb is still ERB. Added ["user", :sort_by_user.t]
  to full_herbaria_index_sorts — the dead reject!("user") in
  nonpersonal_herbaria_index_sorts becomes meaningful.

Herbarium#order_by_user override

AbstractModel's order_by_user joins on :user; Herbarium has
:personal_user. Added a Herbarium-specific scope joining on
:personal_user with the same name-or-login fallback ordering.

Cross-helper cleanup

Removed vestigial `include Tabs::HerbariaHelper` from
Tabs::HerbariumRecordsHelper.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

36 of 37 new or added lines in 8 files covered. (97.3%)

41344 of 42842 relevant lines covered (96.5%)

668.07 hits per line