MushroomObserver / mushroom-observer / 26681282442

97%

push

github

shared/list_search: convert to Phlex Components::ListSearch (#4395)

Replaces `app/views/controllers/shared/_list_search.html.erb` (27 lines) and its single-caller inner `_search_status_autocompleter.erb` (50 lines) with a single Phlex component, `Components::ListSearch` (135 lines). The component owns the Bootstrap panel that wraps the form, the three flat hidden fields, the Stimulus-driven search-status row (status-light + Field-Slip quick-add + name autocompleter), and emits markup-equivalent output for both callers (`projects#show` and `species_lists#show`).

The form posts flat top-level params (`name`, `field_slip`, `object_id`, `object_type`, `project`) to `AddDispatchController#new`, so every field uses the String-keyed `name=` path through the Phlex `FieldHelpers` (`hidden_field("object_id", value: …)`, etc.) — the supported FieldProxy mode, not hand-rolled `<input>` tags. The form has no real backing model; a tiny stub `FormObject::ListSearch` exists only to satisfy `Superform::Rails::Form`'s `model.model_name` requirement.

Both Phlex callers (`Views::Controllers::Projects::Show` and `Views::Controllers::SpeciesLists::Show`) drop their `view_context.render(partial: "shared/list_search", locals: { object: … })` ERB bridges and now `render(Components::ListSearch.new(…))` directly. Both views accept `object_names:` as a new prop, threaded through from the controller, replacing the previous reach-through to the `@object_names` ivar.

`species_lists_controller#show` got pushed one line over `Metrics/ClassLength`'s 250-line limit by the new `object_names:` arg; extracted a one-line `render_phlex_show` helper to recover, matching the existing `render_phlex_new` / `render_phlex_edit` pattern.

Two intentional behavior shifts in the rendered HTML — both call-outs in the PR description for reviewers:

1. **"Field Slip:" capitalization** — the ERB called `form.label("Field Slip:", for: "field_slip", …)`. Rails' `label` helper takes `(method, text = ni... (continued)

50 of 50 new or added lines in 5 files covered. (100.0%)

39744 of 41191 relevant lines covered (96.49%)

676.53 hits per line