MushroomObserver / mushroom-observer / 26682542179

97%

push

github

Preferences form: fix two broken PUTs and move retroactive update links (#4396)

* account/preferences: move retroactive triggers next to their selects + fix broken PUTs

Pre-#4394 the prefs `edit.html.erb` ended with a footer block of three `put_button`s — vote anonymity, filename purge, bulk license updater — sitting after the main `<form>`. #4394 carried that footer block forward into the new Phlex `Edit` view unchanged. This PR moves each retroactive trigger inline next to its semantically-related Privacy select via the select's `with_append` slot, styled as `.btn.btn-outline-default`, and switches their underlying HTTP shape to match what they actually do.

Two of the three were quietly broken under the old layout — flagged by the user, confirmed by route + controller inspection:

- **Vote anonymity.** Pre-Phlex `put_button` to `images_bulk_vote_anonymity_updater_path` (`PUT /images/votes/anonymity`). The route accepts PUT and points at `Images::Votes::AnonymityController#update`, which checks `params[:commit] == :image_vote_anonymity_make_public.l`. The `put_button` sends `commit=<button-label>` which is the localized "Change Image Vote Anonymity", so the check always failed and `image_vote_anonymity_invalid_submit_button` flashed. The real flow is via the GET edit page — it shows current public-vs-anonymous counts and renders its own "Make Public" button (the one that submits a matching commit). The trigger now goes to `images_edit_vote_anonymity_path` as a plain GET `<a>`.
- **Bulk license updater.** Pre-Phlex `put_button` to `images_edit_licenses_path` (`/images/licenses/edit`). That route is GET only — `match(via: [:put, :patch])` lives on `/images/licenses`, a different path. PUT-ing the edit URL 404s. The edit page itself owns the real update form. The trigger now goes to `images_edit_licenses_path` as a plain GET `<a>`.
- **Filename purge.** The only one that's actually a direct mutation: `Images::FilenamesController#update` does `Image.w... (continued)

78 of 79 new or added lines in 6 files covered. (98.73%)

39779 of 41226 relevant lines covered (96.49%)

676.76 hits per line