MushroomObserver / mushroom-observer / 26680380128

97%

Build Type

push

github

Committed by web-flow

Commit Message

account/preferences: convert form + action templates to Phlex (#4394)

Replaces `account/preferences/edit.html.erb` + its 6 section partials (login / privacy / appearance / filters / notes / email) + 3 filter sub-partials + `_put_buttons.html.erb` + `no_email.html.erb` — 13 ERB files, 256 lines — with three Phlex classes totaling 390 lines of rendering logic.

- `Components::AccountPreferencesForm` (`app/components/account_preferences_form.rb`, 326 lines) owns the whole `<form>`. Sections render in order via 6 private `render_*_section` methods. Each section keeps its own submit button so users don't have to scroll to the bottom of the page.
- `Views::Controllers::Account::Preferences::Edit` (`app/views/controllers/account/preferences/edit.rb`) is the action view — adds the page title + context nav, renders the form, then renders the three `PUT`-method bulk-action buttons (vote-anonymity, filename-purge, bulk-license-updater) OUTSIDE the form so a click submits to its own target instead of `PATCH /preferences`.
- `Views::Controllers::Account::Preferences::NoEmail` is the small confirmation page rendered after an unsubscribe link click.

Controller switches to explicit `render(View.new(…))` per the no-Phlex-resolver convention; `render_edit` / `render_no_email` private helpers keep the action bodies thin.

Controller test tweaks (same file):

- `assert_input_value(:user_lichen, nil)` → `:user_lichen, ""` — Phlex's `select_field` marks the empty-value "filter off" option as `selected` when `content_filter[:lichen]` is nil; ERB's pre-conversion output left it unmarked. Visually identical (browsers default to the first option either way) — the new markup more accurately reflects the actual selection state.
- `assert_request(..., result: "no_email")` → explicit `get` + `assert_response(:success)` + `assert_select("body.preferences__no_email")`. `assert_template` doesn't fire on Phlex views, so the body-marker class is the right hook.

Two intentional marku... (continued)

Coverage Stats

165 of 166 new or added lines in 4 files covered. (99.4%)

15 existing lines in 1 file now uncovered.

39698 of 41145 relevant lines covered (96.48%)

674.36 hits per line