MushroomObserver / mushroom-observer / 26634894646

97%

push

github

`Header::ContextNavHelper`: convert dropdown + sidebar builders to Phlex (#4392)

* ## Summary

Converts the top-bar dropdown + mobile sidebar markup builders in `Header::ContextNavHelper` to two Phlex components — `Components::ContextNav::TopBar` (the right-side "Context Actions" dropdown) and `Components::ContextNav::Sidebar` (the `xs`-only collapsible nav). The helper's public API stays the same: views still call `add_context_nav(links)` to populate both `content_for` blocks, and a handful of ERB partials that consumed `context_nav_links(links)` directly (e.g. `users/show/_profile.erb` wraps each link in its own custom `<ul>`) keep that interface too.

## What moved to Phlex

- `add_context_nav_to_top_bar` / `context_nav_dropdown` / `context_nav_dropdown_toggle` / `context_nav_dropdown_menu` → `Components::ContextNav::TopBar`
- `add_context_nav_to_sidebar` / `context_nav_sidebar_links` / `sidebar_nav_link` → `Components::ContextNav::Sidebar`
- The `[text, url, args]`-tuple → HTML dispatch (`button_to` for `:post`, `CrudButton::*` for `:destroy` / `:put` / `:patch`, `link_to` otherwise) lives in `Components::ContextNav::LinkRendering`, a private mixin both components include
- `sidebar_css_classes` (a one-method module — `SidebarHelper` — whose only caller was the sidebar builder) inlines as a `CSS_CLASSES` constant on `Components::ContextNav::Sidebar`

## What stayed in the helper

- `add_context_nav(links)` — the entry-point. Now a 6-line shim that renders the two components into the `content_for` blocks
- `context_nav_links(links, extra_args = {})` — kept for ERB callers that build their own non-dropdown layout
- `context_nav_link(link, extra_args = {})` — the per-link converter
- `merge_context_nav_link_args` / `crud_button_or_link` — supporting methods

The helper module went from ~170 lines to ~85, half-size, but doesn't *just* delegate — it keeps the helper-context (string-returning) version of the link dispatch for ERB callers that need it. ... (continued)

77 of 78 new or added lines in 4 files covered. (98.72%)

39551 of 40982 relevant lines covered (96.51%)

675.92 hits per line