MushroomObserver / mushroom-observer / 26630754906

97%

push

github

LightboxCaption: embed ImageVoteInterface; strengthen test coverage (#4388)

* LightboxCaption: embed ImageVoteInterface; strengthen test coverage

The lightbox overlay (populated from the theater button's
`data-sub-html`) was missing the vote interface. Users could see vote
buttons under the in-page carousel/interactive image but not when
they opened the lightbox to see the image full-size — voting required
closing the lightbox and re-clicking on the small page-context links.

Adds `render_vote_section` to `LightboxCaption`, gated on `@user &&
@image` (matches `images/show/_image_panel.html.erb`'s "login required"
rule), placed between the obs/image caption and the image-links
footer. Anonymous viewers see no vote UI; obs-only pre-render
contexts without an image are also skipped.

Strengthens existing test coverage that previously hid the gap:
- `InteractiveImageTest#test_renders_with_votes_enabled` /
  `#test_renders_with_votes_disabled` previously only asserted that
  `image-sizer` was present (unrelated to votes). Now asserts the
  actual vote-section markers (`#image_vote_<id>`, `.vote-meter`,
  `.vote-buttons`, `.image-vote-links`) — which is what `votes:
  true` is supposed to produce.
- `CarouselTest#test_carousel_item_renders_vote_section` (new) covers
  the same assertion for the carousel-item code path.
- `LightboxCaptionTest`: three new tests for the lightbox vote
  section — present for logged-in user with image, absent for
  logged-out user, absent when no image is in scope.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* LightboxCaption: thread votes: through; suppress N+1 on profile-images

`AccountIntegrationTest#test_profile` failed with a Bullet N+1:
`Image => [:image_votes]` on `/account/profile/images`. The profile-
images reuse partial renders `Components::InteractiveImage.new(...,
votes: false)`, but the lightbox caption — embedded in the theater
button's `data-sub-html` via `BaseImage#lightbox_caption_... (continued)

6 of 6 new or added lines in 1 file covered. (100.0%)

39243 of 40675 relevant lines covered (96.48%)

674.73 hits per line