MushroomObserver / mushroom-observer / 26631317870

97%

push

github

species_lists: convert remaining ERBs to Phlex; add `render_index_view` hook (#4389)

* species_lists: convert 3 partials to Phlex; inline SpeciesListsHelper

Converts the three partials rendered by the species_list show / index
pages and the obs-attach edit page:

- `_details.erb` → `Views::Controllers::SpeciesLists::Details`
  Panel with when / observation count / where / who / projects / notes
  + a download button (`CrudButton::Download` pointed at the irregular
  `new_download_species_list_path` route).
- `_observation.erb` → `Views::Controllers::SpeciesLists::Observation`
  One observation row in the show page — two-column when there's a
  thumb image (interactive image + details), single-column otherwise.
  Permission-gated REMOVE put-button in the top-right.
- `_species_list.erb` → `Views::Controllers::SpeciesLists::Listing`
  One species_list row — used by the index page AND the observation
  obs-attach edit page. Title + place / user on the left, REMOVE or
  ADD put-button on the right (mutually exclusive, depending on
  whether the obs is on the list).

`SpeciesListsHelper` is deleted entirely — its two methods
(`species_list_remove_obs_button`, `species_list_add_obs_button`)
were the only public surface and both inline as private methods on
`Observation` / `Listing`. Modernized the legacy `data: { confirm:
:are_you_sure.l }` (rails-ujs, no-op under Turbo) to the working
`confirm:` kwarg on `CrudButton::Put` — this matches what every
other destroy / put button in the codebase now uses, and the
data-turbo-confirm attribute actually fires Turbo's confirm dialog.

Three callers updated to render the new Phlex classes directly:

- `species_lists/show.html.erb` → renders `Details` and `Observation`
- `species_lists/index.html.erb` → renders `Listing` (collection iter)
- `observations/species_lists/edit.html.erb` → renders `Listing`
  for both `@obs_lists` and `@other_lists`

Two `plain(...)` → `trusted_html(...)` fixes inside `Listing` where
the... (continued)

279 of 281 new or added lines in 13 files covered. (99.29%)

39516 of 40946 relevant lines covered (96.51%)

671.32 hits per line