MushroomObserver / mushroom-observer / 26609188726

97%

push

github

CrudButton: rename, subclasses, btn:/icon: defaults; sweep callers (#4387)

* CrudActionButton: GET branch + route prefix; sweep download_button / edit_button onto it

## CrudActionButton extensions

Two small additions so `Components::CrudActionButton` can replace
all of MO's icon-button helpers, not just the destroy/patch/post/put
form-button family it covered originally:

1. **`method: :get` emits `<a>` (link_to) instead of `<form><button>`
   (button_to).** GET is idempotent — the form wrapper is overkill,
   right-click "Open in new tab" / "Copy link address" / "Save link
   as" all fail on a button, and a `<form>` is block while an `<a>`
   is inline. Internally splits `view_template` into `render_link`
   (GET) and `render_form_button` (everything else), with shared
   `button_content` (icon + `sr-only` name) between them.

2. **Path prefix from `action:` for named-route URLs.** When the
   caller's `action:` is in the `NAMED_ROUTE_ACTIONS` whitelist
   (`:edit`, `:new`, `:download`), the model-target path becomes
   `edit_<type>_path`, `new_<type>_path`, etc. Other actions
   (HTTP verbs like `:patch`, or unset) keep the bare resource path
   — the HTTP method dispatches the controller action via Rails'
   RESTful routes.

## Sweep helpers onto it

Two `LinkHelper` button-helpers were carrying their own hand-rolled
`button_atts` + `link_to` blocks — duplicating the html_options
shape with the rest of the button family, and (as a bonus) leaking
the `:icon` kwarg through to the rendered HTML as an invalid attr
(`<a icon="edit" …>`). Both now delegate to `Components::CrudActionButton`:

- **`edit_button`** — GET-style edit link. Now: `crud_action_button(
  target:, name:, method: :get, action: :edit, **args)`. Renders
  same `<a>` element, minus the bogus `icon=""` attribute.
- **`download_button`** — GET-style download link for a species_list.
  Now: `crud_action_button(name:, target: new_download_species_list_path(...),
  method: :get, action: ... (continued)

168 of 170 new or added lines in 27 files covered. (98.82%)

39237 of 40669 relevant lines covered (96.48%)

664.06 hits per line