MushroomObserver / mushroom-observer / 26550324451

97%

Build Type

push

github

Committed by web-flow

Commit Message

species_lists/write_in: convert form + new template to Phlex; fix AutocompleterField hidden-id slicing (#4386)

Three things, all ratcheting forward:

## 1. Convert write-in form + action template to Phlex

`species_lists/write_in/_form.html.erb` → `Views::Controllers::SpeciesLists::WriteIn::Form`,
`species_lists/write_in/new.html.erb` → `Views::Controllers::SpeciesLists::WriteIn::New`,
and inline `species_lists/form/_fields_for_member.erb` (only ever
rendered from this form) into the new Phlex form's private methods.

The form's fields fall into three groups, all backed by the
recently-generalized field-helper API:

- Top-level params (`approved_names`, `approved_deprecated_names`):
  `hidden_field("approved_names", value: ...)` — String, raw `name=`.
- Non-model nested namespaces (`list[members]`, `member[*]`):
  `text_field("member[lat]", value: ...)`, `checkbox_field("member[specimen]",
  value: "1", checked: ...)`, etc. — String, raw `name=`.
- Model attributes (`:place_name` — a `SpeciesList` column):
  `autocompleter_field(:place_name, type: :location, ...)` — Symbol,
  model-bound.

`new.html.erb` becomes `Views::Controllers::SpeciesLists::WriteIn::New`,
rendered explicitly by `SpeciesLists::WriteInController#new` and the
failure-reload path of `#create` (MO doesn't wire `Phlex::Rails::Resolver`,
so a bare `render(:new)` can't pick up the Phlex action view).

## 2. Fix `AutocompleterField`'s hidden-id field name slicing

`AutocompleterField` auto-derives a paired hidden input — its
`name` is `"<namespace>[<key>_id]"` (e.g. `name="list[members_id]"`
for a visible field named `list[members]`). The implementation
sliced the field's `dom.name` using a regex built from `field.key`:

    field.dom.name.sub(/\[#{field.key}\]$/, "[#{key}_id]")

That works when `field.key` is a leaf identifier (Symbol or simple
String like `:place_name`), but silently fails for FieldProxy
instances built by the String-form helpers, where `field.key`
contains the full n... (continued)

Coverage Stats

104 of 104 new or added lines in 4 files covered. (100.0%)

1 existing line in 1 file now uncovered.

39216 of 40657 relevant lines covered (96.46%)

666.64 hits per line