MushroomObserver / mushroom-observer / 26549298654

97%

push

github

Restore link_icon / modal_link_to to AutocompleterField (Components::Input) (#4385)

* Restore link_icon / modal_link_to to AutocompleterField via Components::Input

PR #4376 ("Centralize helper registrations") removed
`register_output_helper :link_icon` and `register_output_helper
:modal_link_to` from `AutocompleterField`, on the (incorrect)
assumption that the same registrations on `Components::Base` would
cover it via inheritance.

They don't. `AutocompleterField` inherits from
`Superform::Rails::Components::Input` — a Superform gem class — not
from `Components::Base`. With the registrations gone, every
autocompleter call to `link_icon` (in `render_has_id_indicator`,
which produces the green check next to autocompleted entries) and
`modal_link_to` (in the create-link block) raised `NoMethodError`
at render time. System tests like
`AutocompleterSystemTest#test_autocompleter_in_naming_modal` and
`ObservationNamingSystemTest#test_add_and_edit_naming` started
failing because the autocompleter dropdown never appeared (the
`.auto_complete` selector never matched).

Restore the registrations, but at one level up: new
`Components::Input < Superform::Rails::Components::Input` carries
the shared MO output helpers, and `AutocompleterField` (and any
future Input-derived MO component that needs the same helpers)
inherits from `Components::Input` rather than registering each
helper itself.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Document why system tests must bind to port 3000

Add a comment block to `application_system_test_case.rb` explaining
that `Capybara.server_port = 3000` isn't an arbitrary choice — the
Google Maps API key in `app/javascript/controllers/{geocode,map}_
controller.js` is HTTP-Referer-restricted in Google Cloud Console to
`http://localhost:3000/*`. Running tests on any other port (e.g. an
OS-assigned ephemeral port) makes Maps geocoder / autocompleter
calls get rejected, breaking 7 system tests that depend on... (continued)

5 of 5 new or added lines in 2 files covered. (100.0%)

39119 of 40559 relevant lines covered (96.45%)

663.25 hits per line