MushroomObserver / mushroom-observer / 26519536024

97%

push

github

Centralize helper registrations + flatten Phlex view namespaces (#4376)

Three threads in one cleanup:

1. **Tabs auto-include in `Views::Base`.** A `to_prepare` hook in
   `config/initializers/phlex.rb` includes every top-level
   `Tabs::*Helper` module into `Views::Base` after eager-load (prod)
   or on every reload (dev). View classes can now call any tab
   builder (`object_return_tab`, `species_lists_index_tabs`, etc.)
   directly — no `helpers.*` proxy, no per-class
   `register_value_helper`. Nested modules under
   `Tabs::Sidebar::*`, `Tabs::Locations::*`, etc. stay scoped to
   their existing callers.

2. **Drop redundant helper registrations** across 21 view + 3
   component files. The registrations were all already inherited:
   - `q_param`, `add_q_param`, `url_for`, `permission?`,
     `link_to_object`, `user_link`, `location_link`, `help_block`,
     `link_icon`, and 17 others — already on `Components::Base`.
   - `add_page_title`, `add_new_title`, `add_edit_title`,
     `add_context_nav`, `add_project_banner`, `container_class`,
     `content_for` — already on `Views::Base`.
   - All `*_path` and `*_url` named-route helpers — provided by
     `Phlex::Rails::Helpers::Routes` (already in `Components::Base`).
   - `asset_path` — provided by `Phlex::Rails::Helpers::AssetPath`.
   - `*_tabs` and `object_return_tab` — auto-included via the new
     Tabs hook above.

3. **Flatten deep-nested namespaces** in 17 Phlex view files. Per
   `.claude/rules/phlex_conversions.md`'s "Collapse deep namespaces"
   section, the four-level `module Views / module Controllers /
   module X / module Y / class Z` form gets rewritten as
   `module Views::Controllers::X::Y / class Z`. Body indentation
   shifts left by the appropriate amount; trailing `end`s drop to
   match.

Plus one small inline: `project_alias_headers` (a one-line constant
array of localized strings) was registered on
`Views::Controllers::Projects::Aliases::Index` — moved into the
view as a pr... (continued)

485 of 485 new or added lines in 18 files covered. (100.0%)

39097 of 40537 relevant lines covered (96.45%)

666.27 hits per line