MushroomObserver / mushroom-observer / 26519758644

97%

push

github

ProjectsHelper cleanup: inline alias-table rendering + relocate tabs (#4378)

* TrackerRow: inline field_slip_link from ProjectsHelper

`ProjectsHelper#field_slip_link(tracker, user)` had a single caller —
`Views::Controllers::Projects::FieldSlips::TrackerRow` — and a
five-line body. Moves into the view as a private
`render_field_slip_link` method that emits via `link_to` / `plain`
(Phlex's emit-not-return convention, matching the sibling
`render_user_link` at the bottom of the same class).

The helper module loses one method; the view loses one
`register_value_helper` line. Net result is the same code in one
fewer place.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Inline project alias rows into Phlex view; relocate tab helpers

Drop rendering concerns from ProjectsHelper by extracting a Phlex
Views::Controllers::Projects::Aliases::Table that owns headers, row
construction, and the per-row action buttons. Both the index page
and the post-CUD turbo_stream re-render (`_target_update.erb`) now
render the Table, matching the single-use view pattern in
.claude/rules/phlex_conversions.md.

Move `edit_project_alias_tab` and `new_project_alias_tab` from
ProjectsHelper to Tabs::ProjectsHelper — they were misplaced; tab
builders belong with the other `*_tab` methods. The two link helpers
that compose them (`edit_project_alias_link`, `new_project_alias_link`)
still live in ProjectsHelper for now since `Aliases::Widget` registers
them as output helpers.

`link_to` in Phlex is an output helper (emits to buffer); wrap with
`capture` so `make_table` sees a complete cell value rather than the
link being emitted outside the table.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

36 of 36 new or added lines in 4 files covered. (100.0%)

39105 of 40545 relevant lines covered (96.45%)

662.12 hits per line