MushroomObserver / mushroom-observer / 26519524675

97%

Build Type

push

github

Committed by web-flow

Commit Message

species_lists: convert 5 ERB forms + action templates to Phlex (#4375)

* species_lists: convert uploads + observations forms to Phlex; delete dead checklist sub-partial

Two ERB → Phlex conversions, and a dead-code removal:

1. `species_lists/uploads/new.html.erb`'s inline `form_with` →
   `Views::Controllers::SpeciesLists::Uploads::Form`.
   Posts `species_list[file]` (multipart) to
   `SpeciesLists::UploadsController#create`. No controller-contract
   changes — the form binds to the existing `@species_list` model
   and `species_list[file]` matches what the controller already
   reads.

2. `species_lists/observations/_form.html.erb` →
   `Views::Controllers::SpeciesLists::Observations::Form`.
   Posts under `species_list[title]` (model-namespaced) instead of
   the previous top-level scalar `params[:species_list]`. The
   controller's `lookup_species_list_by_id_or_name` is unchanged —
   it accepts a title-string or a numeric id either way — but the
   param read centralizes into a new `species_list_query_param`
   helper that dig's the nested shape. Two helper / test sites also
   updated to the new shape (the link in
   `tabs/species_lists_helper.rb`, the controller test, and the
   `find_field` selector in the autocompleter system test).

3. Delete `species_lists/form/_fields_for_checklist.erb`. Audit
   confirms zero callers anywhere — `grep -rln "fields_for_checklist"`
   only matched the file itself.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* species_lists/downloads: convert report form to Phlex

`_form_species_list_report.html.erb` →
`Views::Controllers::SpeciesLists::Downloads::ReportForm`.

Posts under `species_list_report[format]` via a small new
`FormObject::SpeciesListReport` rather than the previous top-level
`params[:type]` scalar. The report form represents an operation
(format choice) not a model lookup, so a FormObject is the natural
binding. Controller's `@type` setter and the `make_report` case
state... (continued)

Coverage Stats

238 of 238 new or added lines in 18 files covered. (100.0%)

1 existing line in 1 file now uncovered.

39206 of 40655 relevant lines covered (96.44%)

661.11 hits per line