MushroomObserver / mushroom-observer / 26503187301

97%

push

github

checkbox_field: positional choices in Rails shape (#4374)

Two coupled changes:

1. `checkbox_field` now accepts positional `*choices` alongside its
   existing `**options` (parity with `radio_field`). The underlying
   `Field#checkbox(*options, **)` has always supported collection
   mode; the helper just didn't expose it, so collection-mode
   checkboxes had to bypass the helper:

   ```ruby
   render(field(:tag_ids).checkbox(*options))   # before
   checkbox_field(:tag_ids, ["Foo", 1], ["Bar", 2])  # after
   ```

2. `CheckboxField#initialize` now flips incoming `[label, value]`
   pairs to the Superform-internal `[value, label]` shape that
   `Choices::Mapper` expects. This matches PR #4364's
   `SelectField` change — every MO field helper now reads its
   positional choices as `[label, value]` (matching
   `options_for_select`). `select_field`, `radio_field`, and
   `checkbox_field` array mode all use the same shape — no more
   per-helper footgun.

   Rails itself splits the convention: `options_for_select` uses
   `[label, value]` but `collection_check_boxes(:foo, items,
   :value_method, :text_method)` puts the value method first. We
   pick MO-internal consistency over per-helper Rails fidelity.

The fix surfaced while landing the species-lists projects/edit
form's project-membership checkbox group — first new array-mode
caller in the codebase. Existing tests covered Superform-shape;
one in-file test (`field(:number).checkbox([1, "A"], [2, "B"])` —
the only positional-array caller anywhere) updated to
Rails-shape. No production view callers use array-mode yet.

Added a new test exercising the helper path end-to-end with
collection-mode pairs.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

3 of 3 new or added lines in 2 files covered. (100.0%)

38985 of 40433 relevant lines covered (96.42%)

663.94 hits per line