MushroomObserver / mushroom-observer / 26484127777

97%

push

github

Views: pre-register common page-chrome helpers + collapse namespaces (#4373)

Three threads in one commit, all about tightening up the `Views/`
tree introduced over the past few PRs:

1. `Views::Base` now pre-registers the page-chrome helpers every
   action view needs: `add_page_title`, `add_new_title`,
   `add_edit_title`, `add_context_nav`, `add_project_banner`,
   `container_class`, and `content_for`. Subclasses only register
   their *specific* helpers now.

   All MO page-chrome helpers are side-effect-only (they call
   `content_for(...)`), so they're correctly modeled as value
   helpers — return value isn't inserted into rendered output.
   Some classes had them registered as output helpers; centralizing
   on `Views::Base` deduplicates the registrations and fixes the
   kind mismatch.

   Cleaned up redundant registrations on
   `Views::Controllers::Occurrences::{New,Edit,Show}`,
   `Views::Controllers::Checklists::Show`, and
   `Views::Layouts::ApplicationSidebar`.

2. Collapsed the four-level `module Views / module Controllers /
   module X / class Y` indentation in the same four files, per the
   convention in `.claude/rules/phlex_conversions.md`:

   ```ruby
   module Views::Controllers::Occurrences
     class New < Views::Base
   ```

   Sibling-reference cleanups along the way:
   `render(Form.new(...))` and `render(Projects::Form.new(...))`
   instead of fully-qualified `Views::Controllers::...` paths.

3. `checklist_show_title` moves from `Tabs::ChecklistsHelper` into
   `Views::Controllers::Checklists::Show` as a private method —
   its body is pure `:foo.t` symbol-translation lookups, no
   helper-chain dependencies. `checklist_show_tabs` (and the
   `checklist_for_*_tabs` builders it composes) stay in the helper
   because they reach a half-dozen tab helpers across other
   modules that aren't yet accessible from Phlex without explicit
   `helpers.*` plumbing.

   `.claude/rules/phlex_conversions.md` gets a new "Helpers in
   Phle... (continued)

95 of 95 new or added lines in 5 files covered. (100.0%)

38984 of 40432 relevant lines covered (96.42%)

666.98 hits per line