MushroomObserver / mushroom-observer / 26446260061

96%

push

github

occurrences: move + consolidate OccurrenceForm + OccurrenceEditForm; fix 2 N+1s (#4345)

* occurrences: consolidate OccurrenceForm + OccurrenceEditForm into one Views::Controllers::Occurrences::Form

Per #4331 — moves to Views/ AND consolidates the two forms into one.
Pattern: branch on model.persisted? (the convention used by every
other form post-move). Reduces duplication of the matrix-rendering
methods (render_obs_box, render_include_checkbox, render_primary_radio,
render_occurrence_warning) that were copy-pasted between the two.

Mode differences preserved exactly:
- New: source_obs + recent_observations kwargs; source obs is
  always-included with hidden array element + 'Source' label;
  primary radio checked; Stimulus 'occurrence-form' controller +
  'source' fallback on the matrix <ul>.
- Edit: observations + candidates kwargs; renders the primary-obs
  inline detail edit section (location + date); Stimulus controller
  on the <form>; 'first-included' fallback; PATCH via Superform
  auto-emit; candidate matrix below the members.

Same form id 'occurrence_form' for both modes — no derive_form_id
change needed. Two callers (new.rb + edit.rb) updated to pass
'model:' (callers now construct Occurrence.new(primary_observation:
source_obs) explicitly in the new case).

Tests: combined unit-test file with explicit new-mode and edit-mode
sections; all 24 view tests + 73 controller tests + 1 existing
system test pass. No edit-mode system test exists (none existed
pre-consolidation either); manual edit-flow smoke recommended.

* occurrences: add edit-form system test; fix 2 N+1s exposed by it

Adds occurrence_edit_form_system_test.rb covering 4 flows:
1. Form renders members with checked Include + correct primary radio
   + inline primary-obs detail section.
2. Form renders candidates section when the user has recent
   ObservationViews for non-member observations.
3. Unchecking Include + submit actually removes the observation
   from the occurrence (r... (continued)

202 of 202 new or added lines in 7 files covered. (100.0%)

38985 of 40435 relevant lines covered (96.41%)

665.01 hits per line