MushroomObserver / mushroom-observer / 26446266438

96%

push

github

projects: move 17 forms/widgets to Views/ (#4361)

* projects: move 17 forms/widgets to Views/

Per #4331. Largest move so far — 17 single-use-within-projects
components from `app/components/` to
`app/views/controllers/projects/...`:

  Components::ProjectAdminRequestForm
    → Views::Controllers::Projects::AdminRequests::Form
  Components::ProjectAliasForm
    → Views::Controllers::Projects::Aliases::Form
  Components::ProjectAliases
    → Views::Controllers::Projects::Aliases::Widget
  Components::ProjectFieldSlipForm
    → Views::Controllers::Projects::FieldSlips::Form
  Components::ProjectFieldSlipTrackerRow
    → Views::Controllers::Projects::FieldSlips::TrackerRow
  Components::ProjectForm
    → Views::Controllers::Projects::Form
  Components::ProjectGroups
    → Views::Controllers::Projects::Members::Groups
  Components::ProjectListItem
    → Views::Controllers::Projects::ListItem
  Components::ProjectMemberForm
    → Views::Controllers::Projects::Members::Form
  Components::ProjectTargetLocationsWidget
    → Views::Controllers::Projects::Locations::TargetLocationsWidget
  Components::ProjectViolationsForm
    → Views::Controllers::Projects::Violations::Form
  Components::TargetLocationForm
    → Views::Controllers::Projects::Violations::TargetLocationForm
  Components::TrustSettingsForm
    → Views::Controllers::Projects::Members::TrustSettings
  Components::Projects::AdminSubtabs
    → Views::Controllers::Projects::AdminSubtabs
  Components::Projects::LocationsTable
    → Views::Controllers::Projects::Locations::Table
  Components::Projects::ObsFooter
    → Views::Controllers::Projects::Updates::ObsFooter
  Components::Projects::Tabs
    → Views::Controllers::Projects::Tabs

Naming notes:
- `ProjectAliases` becomes `Aliases::Widget` (not `Aliases`)
  because `Views::Controllers::Projects::Aliases` is already the
  module namespace for the aliases action views (edit/index/new/
  show). The class lives one level deeper.
- `TrustSettingsForm` be... (continued)

688 of 688 new or added lines in 33 files covered. (100.0%)

39003 of 40451 relevant lines covered (96.42%)

667.01 hits per line