MushroomObserver / mushroom-observer / 26408331125

96%

main: 96%

push

github

ApplicationForm: derive form id from full controller path (#4355)

* ApplicationForm: derive form id from full controller path

Switches the auto-derive heuristic in `ApplicationForm#derive_form_id`
from "parent module only" to "all controller-path segments". The new
id mirrors the directory structure so it telegraphs where the form
lives:

    Views::Controllers::Account::APIKeys::Form
      → account_api_key_form  (was: api_key_form)
    Views::Controllers::Admin::Donations::ReviewForm
      → admin_donation_review_form  (was: review_form)
    Views::Controllers::Names::Synonyms::Approve::Form
      → name_synonym_approve_form  (was: approve_form)

Why this is the right shape:

1. The id is no longer ambiguous between forms in different
   namespaces. (Before this change, both `Views::Controllers::Licenses::Form`
   and `Views::Controllers::Images::Licenses::Form` auto-derived to
   `license_form` — a silent collision.)
2. Reading an id in HTML/tests now tells you where the form's source
   file lives.
3. Future moves get the right id with no explicit `id:` override
   needed (most prominently the names cluster — see #4354 — which
   was passing 8 explicit overrides; this commit drops them).

Renames that ride along (form ids change for these forms):

    api_key_form              → account_api_key_form
    login_form                → account_login_form
    email_new_password_form   → account_login_email_new_password_form
    profile_form              → account_profile_form
    banner_form               → admin_banner_form
    manager                   → admin_blocked_ip_manager
    donation_form             → admin_donation_form
    review_form               → admin_donation_review_form
    merge_request_form        → admin_email_merge_request_form
    name_change_request_form  → admin_email_name_change_request_form
    webmaster_question_form   → admin_email_webmaster_question_form
    session_form              → admin_session_form
    bonuses_for... (continued)

21 of 21 new or added lines in 9 files covered. (100.0%)

38991 of 40443 relevant lines covered (96.41%)

662.31 hits per line