MushroomObserver / mushroom-observer / 26400117616

99%

push

github

admin: move 9 forms to Views/ (#4348)

* admin: move 9 forms to Views/

Per #4331:
- Components::AdminSessionForm
    -> Views::Controllers::Admin::Session::Form
- Components::BannerForm
    -> Views::Controllers::Admin::Banners::Form
- Components::DonationForm
    -> Views::Controllers::Admin::Donations::Form
- Components::DonationsReviewForm
    -> Views::Controllers::Admin::Donations::ReviewForm
- Components::IpsManager
    -> Views::Controllers::Admin::BlockedIps::Manager
- Components::MergeRequestForm
    -> Views::Controllers::Admin::Emails::MergeRequests::Form
- Components::NameChangeRequestForm
    -> Views::Controllers::Admin::Emails::NameChangeRequests::Form
- Components::UserBonusesForm
    -> Views::Controllers::Admin::Users::BonusesForm
- Components::WebmasterQuestionForm
    -> Views::Controllers::Admin::Emails::WebmasterQuestions::Form

Admin/table (10th item from the audit) doesn't actually exist; the
audit was stale.

10 ERB callers updated + 3 admin/emails controllers (which use
form_class: in ModalTurboForm dispatch). 36 view tests + 44
controller tests + 10 integration tests pass.

Tightened several forbidden body-wide assertions in the moved test
files to scoped selectors (label[for='...'], .textile, etc.) per
.claude/rules/testing.md. The .textile scope is needed for the .tp
(textile-paragraph) helper's output —  wraps the rendered
text in <div class='textile'>...</div>, so the outer p tag emitted
by  doesn't directly contain the text.

* Admin form tests: tighten assertions to specific elements

Replace remaining `assert_includes(html, ...)` substring checks with
element-scoped `assert_html(..., text:)` / `attribute:` selectors per
the testing rule ("text lives in SOME element — find it").

- Email forms: scope `:NAME.l`, `:LOGIN_NAME.l`, name/value pairs to
  their labels and adjacent `p.form-control-static` paragraphs;
  webmaster reply-to → input `value` attr; question → textarea text.
- Donations review: pull all `table.tabl... (continued)

209 of 210 new or added lines in 9 files covered. (99.52%)

38963 of 40418 relevant lines covered (96.4%)

662.69 hits per line