MushroomObserver / mushroom-observer / 26400115041

99%

push

github

account: move 4 forms to Views/ (#4347)

* account: move 4 forms to Views/

Per #4331:
- Components::AccountProfileForm
    -> Views::Controllers::Account::Profile::Form
- Components::AccountSignupForm
    -> Views::Controllers::Account::Form
    (keeps explicit id 'account_signup_form' — integration test
    uses it in within(...) blocks; the default Views/-derived id
    would be 'account_form' which loses the 'signup' specificity)
- Components::LoginForm
    -> Views::Controllers::Account::Login::Form
- Components::EmailNewPasswordForm
    -> Views::Controllers::Account::Login::EmailNewPasswordForm
    (keeps descriptive suffix — sibling to Login::Form since the
    login controller has multiple form-bearing pages)

4 ERB callers updated. 56 view + controller + integration tests
pass. Tightened a few forbidden `body, text:` assertions in the
moved test files (per .claude/rules/testing.md).

* Login form: restore help-text content assertions

Add ids to the two help `.form-group` wrappers
(`login_forgot_password`, `login_having_problems`) so the form-test
can scope assertions to each block. Restores the original
`text: :login_having_problems.tp.as_displayed` and
`text: :login_forgot_password.tp.as_displayed` checks alongside the
link checks, scoped via the new ids — no body-wide assertions.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

106 of 106 new or added lines in 4 files covered. (100.0%)

38953 of 40408 relevant lines covered (96.4%)

667.91 hits per line