lsm / neokai / 25867795621

81%

Build Type

push

github

Committed by web-flow

Commit Message

feat: cache gate-open state to skip re-evaluation on every message (#1894)

* feat: cache gate-open state to skip re-evaluation on every message delivery

Once a gate evaluates to open, subsequent deliverMessage/canDeliver calls
skip re-evaluation — the gate's purpose is to gate *activation*, and after
that canSend topology authorization controls messaging.

Cache is bypassed for cyclic channels whose gate has resetOnCycle=true,
where the gate must always re-evaluate to enforce revision loops.

The cached open state is cleared when incrementAndResetCyclicChannel
resets gate data, ensuring the next delivery re-evaluates against fresh data.

* fix: address review feedback on gate-open cache

- Remove cacheGateOpened from canDeliver to keep it side-effect free
  (P1: a UI readiness check must not permanently cache a gate as open)
- Add evictRunCache() to prevent unbounded memory growth in long-lived
  daemons; call it when archived runs are detected
- Fail closed when cached gate definition disappears from workflow
  (force re-evaluation so evaluator returns "Gate not found")
- Add evictRunCache test

* fix: check gate existence before cyclic shortcut in mustReevaluateGate

Move the gate definition existence check before the non-cyclic channel
early return so that ALL channels (not just cyclic ones) re-evaluate
when the gate definition disappears from the workflow, failing closed
with "Gate not found" instead of silently allowing delivery.

Also evict gate-open cache on terminal run reopen in activateNode.

* fix: evict gate-open cache on run completion via event bus

Subscribe to `space.workflowRun.completed` in ChannelRouter to
automatically evict opened-gate cache entries when runs transition
to terminal status (done/cancelled/blocked). Add `destroy()` method
for cleanup. Prevents unbounded cache growth in long-lived routers.

* fix: make gate-cache event bus subscription opt-in

Add `subscribeToRunCompletion` config option (defaults to false) so
only... (continued)

Coverage Stats

8334 of 11605 branches covered (71.81%)

Branch coverage included in aggregate %.

170 of 170 new or added lines in 8 files covered. (100.0%)

51 existing lines in 1 file now uncovered.

66877 of 79628 relevant lines covered (83.99%)

291.97 hits per line